rdev icon indicating copy to clipboard operation
rdev copied to clipboard

remove winapi as dependency

Open sn99 opened this issue 2 years ago • 3 comments

The changes include, Migrating from winapi to windows-sys: winapi is no longer maintained in favor of windows-rs which is provided by Microsoft itself. It should provide more robustness against future windows upgrade and better compile and runtime guarantees.

This is the continuation of #97

  • You were right about cargo profile changes, they are overwritten by end binary
  • I have removed any clippy changes, they should have been a separate pull
  • I had no idea about global .gitignore, so that's a pretty good thing to learn
  • I have put the types in mod.rs as public
  • I did not undertsand your comment about removing the global HOOK, aren't we modifying it at set_key_hook & set_mouse_hook

sn99 avatar Jan 31 '23 06:01 sn99

I did not undertsand your comment about removing the global HOOK, aren't we modifying it at set_key_hook & set_mouse_hook

You moved it's location (or the diff wasn't smart enough to put it close enough). It's all good.

Narsil avatar Jan 31 '23 11:01 Narsil

Thanks for the big refacto.

This PR looks much cleaner to me, as the type changes do stand out much more than they used to. They still feel weird, but are necessary since they are differences in the original crates..

As I mentioned in the previous PR, I'm unlikely to merge before having checked extensively this (which I can't promise will happen any time soon). If anyone happens to take this PR out for a spin and it works (or has bugs) it would be nice to share here (if many people report it's working, I'll take that as a good sign, and maybe not test as much and merge earlier).

Narsil avatar Jan 31 '23 11:01 Narsil

Nice, thanks for pointing out my mistakes, it has indeed idk how to say useful for me

sn99 avatar Feb 01 '23 05:02 sn99