Chris Cranford

Results 365 comments of Chris Cranford

Hi @garawaa do you have a `.gd` and `.torch` files you've used as comparison?

Hi @neilfranci, thanks for the report. The `SceneTreeDock` is a control managed by the Godot Editor, so this needs to be changed in the upstream engine repository and not in...

Just tested this against Godot 4.3.stable and it seems Godot has fixed this. If this is still an issue, please open an issue in the upstream Godot repository.

> You need to bind compatibility methods, see [here](https://docs.godotengine.org/en/latest/contributing/development/handling_compatibility_breakages.html) Even if these methods were introduced in an alpha/beta build of Godot 4.3? The practical reason behind this PR in the...

> The `current_value` in `popup_property_selector()` seems to do nothing. Nothing is selected no matter what I tried to use. I wonder if that is a bug in the actual base...

Hi @KoBeWi so I checked the code in the `property_selector.h` and `property_selector.cpp` files and it does seem that while one can pass the current "selected" value into the dialog, the...

As I see Remi has moved this to 4.4, what's the final verdict then here?

Can someone point me to an example of compatibility methods, I plan to update this PR with the fix & I'd like to get this in merge shape asap. Thanks!

@KoBeWi added logic for the "current_value" matching for properties/methods & added compatibility methods. Would you mind giving this another pass from your PoV? Thanks!

> Almost. The view is not centered on the property, but awkwardly cut at the top I'll take a look and see if I can reproduce it; however, I used...