keepass-diff icon indicating copy to clipboard operation
keepass-diff copied to clipboard

Missing release tag for 1.2.0

Open panicgh opened this issue 2 years ago • 9 comments

https://crates.io/crates/keepass-diff/versions shows that there is already a 1.2.0 release, but this git repo does not contain a corresponding tag. It would be nice if the respective commit was tagged.

panicgh avatar Nov 19 '23 18:11 panicgh

@Narigo crates.io is now showing v1.2.0 so this issue is resolved.

mrghosti3 avatar Nov 24 '23 13:11 mrghosti3

I think the issue is that I forgot to add a tag to the Git which commit is the 1.2.0 version. I need to add this here still. Thanks for the heads-up btw @panicgh !

Narigo avatar Nov 24 '23 13:11 Narigo

Since that version is uploaded to crates.io the issue can be closed.

mrghosti3 avatar Mar 06 '24 14:03 mrghosti3

I don't know rust. How can I verify from which git commit a crates.io artifact comes from?

panicgh avatar Mar 30 '24 23:03 panicgh

Huh, apparently v1.1.4 is also missing from the git main branch.

@Narigo could you add both v1.2.0 and v1.1.4 tags when you will be available?

mrghosti3 avatar Apr 07 '24 12:04 mrghosti3

@mrghosti3 do you happen to know a good way how to find out on which commit the publish has been done? 😬 I'm pretty sure I always did do publish on a commit, but I missed tagging them. I'm sure I did some additional Readme / doc commits after the last publish so I need to find out which one was the actual one.

My idea would be to download the version from crates.io and manually check those commits against it. Is that the best idea or is there a tool out there which can do this for me? 😬 It sounds like a pretty time consuming process and as one can see in my activities, keepass-diff is not my top priority currently...

Narigo avatar Apr 07 '24 21:04 Narigo

I'd suggest scanning through the git history for changes in Cargo.toml. This may not give the exact commit when publish was done, but it will eliminate a lot of the other commits. Maybe looking into some commits after you could tag them as definitive version release?

Command for that in bash I use:

$ git log -p Cargo.toml

You could the search for keywords like version in the pager.

mrghosti3 avatar Apr 07 '24 22:04 mrghosti3

Hey, someone scanned all the repos and put it online: https://news.ycombinator.com/item?id=40698536

There is [email protected] in there as well: image

Does that mean I can safely tag this commit with 1.2.0 then? https://github.com/Narigo/keepass-diff/commit/08344c5c1d91dd6095af9b3e854bd453278a018c 😅

I'm sorry there is so much going on here, I didn't even get around to fix this and look into all the issues lately

Narigo avatar Jun 16 '24 21:06 Narigo

Hey, someone scanned all the repos and put it online: https://news.ycombinator.com/item?id=40698536

There is [email protected] in there as well: image

Does that mean I can safely tag this commit with 1.2.0 then? 08344c5 😅

I'm sorry there is so much going on here, I didn't even get around to fix this and look into all the issues lately

I pulled the .crate (which is just .tar.gz) file from crates.io and diffed the contents. The only differences is in their version of Cargo.tom, which generated by cargo, and some other configs. But the code, docs, tests and even the lock files match up with the commit you specified. I do believe, that commit 08344c5 is the right one to tag as v1.2.0.

mrghosti3 avatar Aug 17 '24 15:08 mrghosti3