Naomi icon indicating copy to clipboard operation
Naomi copied to clipboard

Remove profile value passing

Open aaronchantrill opened this issue 4 years ago • 4 comments

Detailed Description

There are a lot of places that expect the configuration to be passed in as a structure. Now that the configuration is stored in a public static module, it is no longer necessary to pass the values from module to module, but a lot of modules expect a copy of the config/profile to be passed in. This adds extra complexity to the code and confusion about the "proper" way to access profile values.

Context

This change is just to reduce complexity and increase readability.

Possible Implementation

The implementation is simple. Simply remove every reference to config. from the existing codebase and replace them with profile.get(, default), then remove every place that a module is specifically waiting for or passing a config.

This is pretty simple and would be a good way for someone to learn something about the structure of the code base. I am happy to provide additional support. Unfortunately, this is one of those projects that makes minor changes to a lot of files in this project.

aaronchantrill avatar Jun 26 '20 21:06 aaronchantrill

Assign me i will work on it

Pratikdate avatar Oct 02 '23 02:10 Pratikdate