nango icon indicating copy to clipboard operation
nango copied to clipboard

[nan-903] add optional integration-id

Open khaliqgant opened this issue 9 months ago • 2 comments

Describe your changes

If a user has repeated sync names then we (nango) might not know how to resolve the script to run in a dry run

integrations:
  provider-1:
   syncs:
     foo:
  provider-2:
    syncs:
      foo:

This allows a user to pass in an optional flag of integration-id to identify provider-1 or provider-2

nango dryrun foo unique-connection --integration-id provider-2

Issue ticket number and link

NAN-903

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • [ ] I added tests, otherwise the reason is:
  • [ ] I added observability, otherwise the reason is:
  • [ ] I added analytics, otherwise the reason is:

khaliqgant avatar May 09 '24 08:05 khaliqgant

sidenote: I would love if all dryRun params could be named including connection and sync name because I always forgot in which order there are supposed to be passed.

Yeah same. That is a big change though as dry run is a very often used command cc/ @bastienbeurier

khaliqgant avatar May 09 '24 17:05 khaliqgant