nango icon indicating copy to clipboard operation
nango copied to clipboard

feat(proxy):add fallback to proxy base_url

Open hassan254-prog opened this issue 1 year ago • 1 comments

Describe your changes

Continuing from this, https://github.com/NangoHQ/nango/pull/1770#discussion_r1526495126. We need to have a fallback incase api_base_url_for_customer field is not populated in the connection configuration. I have also added a unit test for this..

hassan254-prog avatar Mar 18 '24 21:03 hassan254-prog

how many customers use the gong integration in prod. If number is small, can we coordinate with them to update their connection instead of making the providers definition and code more complicated?

TBonnin avatar Mar 19 '24 12:03 TBonnin

Since we have no one using Gong in production, we can successfully close this follow-up PR.

hassan254-prog avatar May 28 '24 12:05 hassan254-prog

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8205899 Triggered Generic Password e5c468cb45ed31522b98f8577557850c0e174bcd dev/docker-compose.dev.yaml View secret
8205899 Triggered Generic Password e5c468cb45ed31522b98f8577557850c0e174bcd docker-compose.yaml View secret
8205899 Triggered Generic Password e5c468cb45ed31522b98f8577557850c0e174bcd dev/docker-compose.dev.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Aug 02 '24 16:08 gitguardian[bot]