Nancy icon indicating copy to clipboard operation
Nancy copied to clipboard

Where is Nancy.Json.JsonSettings.MaxJsonLength in Nancy 2.x?

Open jetic83 opened this issue 4 years ago • 5 comments

Prerequisites

  • [x] I have written a descriptive issue title
  • [x] I have verified that I am running the latest version of Nancy
  • [x] I have verified if the problem exist in both DEBUG and RELEASE mode
  • [x] I have searched open and closed issues to ensure it has not already been reported

Description

I just upgraded Nancy from an old version to 2.0.0. Then I found Nancy.Json.JsonSettings is gone. I have tried to find MaxJsonLength in Nancy.Json.JsonConfigurationExtensions.Json.

Steps to Reproduce

System Configuration

  • Nancy version: 2.0.0
  • Nancy host
    • [x] Nancy.Hosting.Aspnet
    • [ ] Nancy.Hosting.Self
    • [ ] Nancy.Owin ()
    • [ ] Other:
  • Other Nancy packages and versions:
  • Environment (Operating system, version and so on): Windows 10, Visual Studio Community 2019
  • .NET Framework version: 4.7.2
  • Additional information:

jetic83 avatar Sep 10 '19 19:09 jetic83

Is there a specific use case where no longer having the length limit is a problem?

** Disclaimer: Not a member of the Nancy team, just someone looking at the issue via codetriage.com

starskythehutch avatar Oct 19 '19 20:10 starskythehutch

I want to increase the length limit. Do you imply there is no length limit anymore? I assume there is still a limit, but Nancy removed the possibility to change it.

jetic83 avatar Oct 19 '19 20:10 jetic83

Looking through the codebase of the previous version the limit was actively enforced, whereas in 2.0.0 it is not. It would appear that there is no longer a limit.

Have you tried it with a large amount of data that would have failed in 1.4.x?

On Sat, 19 Oct 2019, 21:57 Peter, [email protected] wrote:

I want to increase the length limit. Do you imply there is no length limit anymore? I assume there is still a limit, but Nancy removed the possibility to change it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NancyFx/Nancy/issues/2980?email_source=notifications&email_token=AAJGF3IDORUSGXGUYOZ5GC3QPNYFNA5CNFSM4IVL5IAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX4Q2A#issuecomment-544196712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJGF3MO6RKFPV542MTGQPDQPNYFNANCNFSM4IVL5IAA .

starskythehutch avatar Oct 20 '19 08:10 starskythehutch

I have the same question

allycs avatar Dec 18 '19 07:12 allycs

I have the same question

I have solved the problem

allycs avatar Dec 19 '19 07:12 allycs