NanoLimbo icon indicating copy to clipboard operation
NanoLimbo copied to clipboard

Create Dockerfile and docker's compose.yml file

Open dimaguy opened this issue 2 years ago • 3 comments

This PR provides a Dockerfile capable of compiling the source code with just doing DOCKER_BUILDKIT=1 docker build and running it inside of a container. Together with it is bundled a compose.yml file, which requires Docker CE to be installed (not the same as regular distro provided docker, haven't tested with it though). This can easily be used to create an image for the end user to pull from the docker registry.

Fixes #13

dimaguy avatar May 08 '22 15:05 dimaguy

I'm sorry I haven't noticed the comments until now, must've missed in my inbox. I can concede in most comments except the last one, the indentation seems correct in the bind mounts

dimaguy avatar Sep 21 '22 20:09 dimaguy

the indentation seems correct in the bind mounts

I guess I've seen it both ways in YAML, and it doesn't really affect the parsing. (I deleted that change just now, I wasn't sure how else to remove the suggestion)

BBaoVanC avatar Oct 01 '22 03:10 BBaoVanC

Should'nt the file for docker compose be named docker-compose.yml instead of just compose.yml ?

docker-compose.yml is legacy naming, currently compose.yml is the go-to given that it is meant to be a more broad standard than just docker

dimaguy avatar Oct 25 '22 20:10 dimaguy