Nameless icon indicating copy to clipboard operation
Nameless copied to clipboard

Hardcoded language terms

Open DominikSLK opened this issue 1 year ago • 3 comments

Describe the issue

https://github.com/NamelessMC/Nameless/blob/0396359337122b8ee271ebab9b877c00aa53b288/modules/Core/classes/Group_Sync/NamelessMCGroupSyncInjector.php#L17

https://github.com/NamelessMC/Nameless/blob/0396359337122b8ee271ebab9b877c00aa53b288/modules/Core/classes/Group_Sync/MinecraftGroupSyncInjector.php#L17

https://github.com/NamelessMC/Nameless/blob/0396359337122b8ee271ebab9b877c00aa53b288/modules/Discord%20Integration/classes/DiscordGroupSyncInjector.php#L17

NamelessMC Version

2.1.0

To Reproduce

No response

Expected Behaviour

No response

Screenshots

No response

Additional Information

No response

DominikSLK avatar Jul 24 '23 14:07 DominikSLK

Is this shown anywhere in StaffCP?

Derkades avatar Jul 24 '23 17:07 Derkades

yes it is on the page where you select groups for group sync

DominikSLK avatar Jul 24 '23 19:07 DominikSLK

Not sure how to fix this with how it works at the moment.

Let's say we pass a Language instance into the getName method to allow for translations. Currently we have no context as to which Language instance to use - imagine there is a custom module which adds injectors (even in the case of Discord Integration) - the code would not know which Language instance to pass in.

samerton avatar Jul 25 '23 16:07 samerton