MERN-Gurujii-dev icon indicating copy to clipboard operation
MERN-Gurujii-dev copied to clipboard

added docker

Open atharvaze opened this issue 3 years ago • 5 comments

Related Issue

issue #90

  • Info about the related issue Using docker to simplify dev setup Closes: #[issue number that will be closed through this PR] #90

Describe the changes you've made

added docker and docker-compose files provided an option for a user to run mongo separately on a container

Give a clear description what modifications you have made

Type of change

What sort of change have you made: The project can be run on docker by using: docker-compose -f dev-docker-compose.yml up --build

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [x] Enhancement in the existing features
  • [ ] Other

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

  • [x] My code follows the guidelines of this project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly whereever it was hard to understand.
  • [x] My changes generate no new warnings.
  • [x] I have verified/tested my code by running it locally.

Additional Info (optional)

Any additional information you want to give

atharvaze avatar Apr 25 '21 18:04 atharvaze

Your one check is failing. Kindly fix that.

sagar-barapatre avatar Apr 27 '21 03:04 sagar-barapatre

@sagar-barapatre pls review

atharvaze avatar Apr 27 '21 08:04 atharvaze

@sagar-barapatre pls review

atharvaze avatar Apr 29 '21 08:04 atharvaze

Actually, I don't know how to test this on my system, so can you please tell a Lil bit about it?

Namanl2001 avatar May 04 '21 19:05 Namanl2001

Actually, I don't know how to test this on my system, so can you please tell a Lil bit about it? Ensure u have docker desktop installed and running. Run the command: docker-compose -f dev-docker-compose.yml up --build

atharvaze avatar May 04 '21 19:05 atharvaze