bower-videogular-youtube
bower-videogular-youtube copied to clipboard
NamPNQ
Vimeo integration WIP
Ive made some prototype i would like you to take a look at this , currently as a gist , ill be polishing it of course.
https://gist.github.com/rubenCodeforges/bd876bd40343d0f68616
@2fdevs had you have a chance to take a look at it ? BTW i have deployed it on staging , its getting QAed for 1 week after i get the reports ill be going in to polishing stage .
Cool. I'll take a look at it during the weekend (but I'm not part of the videogular team ;-) )
@keckelt it doesnt matter , if you can give some notes and bug reports , that will help to enhance the whole stuff ;)
@keckelt this is an open source project, everybody is part of the videogular team ;-)
@rubenCodeforges I will take a look to it deeply this weekend. I saw it very quickly and it looks good :)
A good suggestion could be having two directives vg-youtube and vg-vimeo sharing the same controller. However, this could be a problem if you want to combine youtube and vimeo videos inside the same player, in that case combining both in the same directive is a better approach.
Maybe we should rename this module to videogular-youtube-vimeo xD
What do you mean with combine? One after another? Am 16.10.2015 1:23 nachm. schrieb "Two Fucking Developers" < [email protected]>:
@keckelt https://github.com/keckelt this is an open source project, everybody is part of the videogular team ;-)
@rubenCodeforges https://github.com/rubenCodeforges I will take a look to it deeply this weekend. I saw it very quickly and it looks good :)
A good suggestion could be having two directives vg-youtube and vg-vimeo sharing the same controller. However, this could be a problem if you want to combine youtube and vimeo videos inside the same player, in that case combining both in the same directive is a better approach.
Maybe we should rename this module to videogular-youtube-vimeo xD
— Reply to this email directly or view it on GitHub https://github.com/NamPNQ/bower-videogular-youtube/issues/45#issuecomment-148688492 .
@keckelt like it is now in my gist , 1 directive and we check is a url a vimeo or a youtube with a simple regexp match . @2fdevs Thanks ill plan also on weekend to tune a bit , as it needs some more methods for controlling vimeo. A known bug now is when clicking on the sound icon ( mute unmute ) i dont know a method in videogular for that , so that i can send a event to vimeo. so for now this doesnt work. Also i didnt found on vimeo doc how to hide player controlls . For now videogulars controlls ( play btn etc ) are on top of vimeos.