EasySpider icon indicating copy to clipboard operation
EasySpider copied to clipboard

Dictionary's get replace catch exception in first three if case

Open touero opened this issue 2 months ago • 5 comments

  1. Using dictionary's get replace catch exception in first three if case.
  2. Adding new IntEnum class for every item key word option in graph.

touero avatar Apr 27 '24 16:04 touero

All finish in preprocess.

touero avatar May 04 '24 03:05 touero

I think line 254 to 256 can be changed to parameters["cookies"] = parameters.get("cookies", "") to make it more concise, can you check if correct and change to the more concise format? Fits for all remaining parts.

NaiboWang avatar May 07 '24 04:05 NaiboWang

That is indeed more concise, but I referred to the previous writing method and was worried that the variable cookies would be used later, so I did not change it. If you think it is okay, I can make the change.

touero avatar May 07 '24 13:05 touero

I think line 254 to 256 can be changed to parameters["cookies"] = parameters.get("cookies", "") to make it more concise, can you check if correct and change to the more concise format? Fits for all remaining parts.

Already do that.

touero avatar May 07 '24 13:05 touero

Thank you for your help! Will check all the codes in the next few days.

NaiboWang avatar May 07 '24 17:05 NaiboWang