WIP: Performance tuning: rendering worldmap objects

[vpithart]

Why?

It's slow. Typical workflow on the worldmap: zoom in, zoom in, zoom in, drag, drag, drag, zoom out ... had caused excessive browser load when re-rendering all the objects on the map.

How?

• UI and call_ajax() synchronization. After fast successive map moves, only last of (often overlapping in time) getMapObjects' results are being rendered.
• ~~Avoid double render. After a map view is dragged (not zoomed), most of the objects stay visible. Only those new are rendered, and old (out of viewport) are removed.~~
• Render less out-of screen objects. Extra area shrunk from 95% to 50%.
• Newer leaflet. The [leafletjs] library is upgraded from ancient v0.7 to v1.6.

[ekrichbaum]

I was thinking about the leaflet cleanup as well. I like pulling it back out to a lib that can be more easily swapped for versions... I'm going to merge this into mine and give it a run. Thanks.

[ekrichbaum]

share/frontend/nagvis-js/js/ViewMap.js 128 this.removeAllObjects() is missing ;

My maps aren't heavy enough to really see much performance change, I think, but no ill effects for sure.

[ekrichbaum]

well. may have spoken too soon but haven't narrowed down when it happens. do a lot of zoom in and out with movement around and get a second copy of all the lines and objects overlayed.

Seems to be related to zoom as I haven't been able to get it from just moving around and they seem to alway be different scales. Doesn't seem related to the ElementLine changes at least but it'll take a while to put these back in and out to narrow further.

[ekrichbaum]

Doesn't seem to have related to the ViewMap changes.

[ekrichbaum]

Seems to be in the ViewWorldmap changes. Another missing ; after this.last_zoom = g_map.getZoom() line 116

Adding back the this.render(); // re-render the whole map seems to correct the issue.

[ekrichbaum]

sorry for the run ons. and:

        if (this.last_zoom !== g_map.getZoom())
            this.handleZoomEnd(lEvent)
        else
            this.handleDragEnd(lEvent)

needs ; and {} for style conformity.

[ekrichbaum]

Hmm. And don't seem to be able to hover the lines or icons anymore. Reverting these changes completely at this point.

Reverting ViewWorldmap.js got hover back as well. I'm going to leave currently with all of the changes except ViewWorldmap.js. Haven't seen any other ill effects at this point that way.

[vpithart]

Thank you @ekrichbaum for testing it too. I' got also double rendering issue, not easily reproducible so far; working on it.

[vpithart]

I quit an attempt to optimize worldmap rendering. Although partial rendering after moveend map event is faster, I'm out for now. It causes too many usability problems (misplaced objects moved after map drag, misplaced new objects, wrong coordinates, ...). No quick fix seems feasible.

[LarsMichelsen]

Shall we close the pull request? Or are there still some commits that we should take over?

[vpithart]

It's still to merge. Of the 4 planned enhancements (UI and call_ajax() synchronization, Avoid double render, Render less out-of screen objects, Newer leaflet) only "avoid double render" is reverted, and the rest is ready.

The performance boost is just slight though.

To really boost it, rendering of the worldmap objects would need complete rework and perhaps tighter integration with leaflet. Maybe later.

[vpithart]

We've fond dome minor compatibility problems with the new leaflet. Marking this WIP until thoroughly tested.