Nadrieril

Results 511 comments of Nadrieril

Could you please split this PR into several for the many features it implements? I see at least: - Remove the redundant `TraitDeclRef`s in `TraitRefKind` (that one could just be...

Sorry, I didn't mean that the PRs should be independent. It's ok if one PR depends on another. What I want is to be able to review one change at...

Thanks for the minimized bug! I can reproduce it, and I understand it: we're keeping the `impl` around after monomorphization, and it referes to the _polymorphic_ version of `Point`, which...

That would be quite delightful. While we probably can't predict the number of items we'll extract, we could show a count of "items extracted/items left to extract", which is observable...

> I think the bar should also show the progress of Cleanups to be made? Oh yeah, that too

More detailed instructions: - First challenge is finding a Rust library that does this nicely (https://crates.io/crates/tqdm or https://crates.io/crates/kdam look good); - Then, there are two places where we could track...

(After private discussion) Closing for now, please reopen if you manage to find a reproducer that triggers the error with `make test`.

Yep, managed to reproduce in the end: it's a panic that only occurs when tracing is on, it's in the printing routine of a `rustc_middle::TraitRef`with no `Self`.

Easy fix would be to translate them to the `_` pattern. This would make the output pattern too general, but I also don't want the name matcher to be able...