nypl-design-system icon indicating copy to clipboard operation
nypl-design-system copied to clipboard

DSD-1799: Add closeOnBlur to FilterBarInline

Open jackiequach opened this issue 7 months ago • 2 comments

Fixes JIRA ticket DSD-1799

This PR does the following:

  • Adds closeOnBlur prop to the render prop function to apply the appropriate prop value to MultiSelect children.
  • Cleans up the FilterBarInline stories by unnesting render prop functions.

How has this been tested?

  • Locally in Storybook

Accessibility concerns or updates

Accessibility Checklist

  • [ ] Checked Storybook's "Accessibility" tab for color contrast and other issues.
  • [ ] The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
  • [ ] For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
  • [ ] For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
  • [ ] The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

  • [ ] I have updated the Storybook documentation and changelog accordingly.
  • [ ] I have added relevant accessibility documentation for this pull request.
  • [ ] All new and existing tests passed.

Front End Review:

  • [ ] Review the Vercel preview deployment once it is ready.

jackiequach avatar Jul 26 '24 19:07 jackiequach