Checkbook icon indicating copy to clipboard operation
Checkbook copied to clipboard

Browser driver executables checked in

Open cecilia-donnelly opened this issue 7 years ago • 0 comments

I notice that on the develop branch a few binary executables have been checked in to source/tests/functional/NYCAutomationTest/src/main/resources/support/. They look like drivers for Chrome on different platforms.

However, when I remove those from my tree and run mvn test, I get the same results as I do with them present, perhaps because of the import org.openqa.selenium.chrome.ChromeDriver; line in Driver.java.

Is that expected? Should tests work without these executables? What about on other operating systems? (I'm working on Debian Linux).

If the tests will run without these executables, then I think we should remove them. New contributors are unlikely to want to run binaries from an unknown source. I've made this commit, branched off of the develop branch, as an example of removing the executables: https://github.com/OpenTechStrategies/Checkbook/commit/c3480c7b5cb15e831c50b1f195b46333067b2126.

If the tests won't run without these executables on other operating systems, let me know and I will do more research to find out how to get those drivers without packaging them in this tree.

cecilia-donnelly avatar Mar 30 '17 18:03 cecilia-donnelly