imx-kobs icon indicating copy to clipboard operation
imx-kobs copied to clipboard

supported geometry check broken?

Open rhubert opened this issue 4 years ago • 0 comments

Hi, I've some trouble with a 2K+128B OOB Flash on a i.MX8. While debugging the code I found this check:

		/* verify it's a supported geometry */
		if (plat_config_data->m_u32Arm_type != MX7 &&
			plat_config_data->m_u32Arm_type != MX8Q &&
			plat_config_data->m_u32Arm_type != MX8MQ &&
			plat_config_data->m_u32Arm_type != MX8MN &&
			plat_config_data->m_u32Arm_type != MX8MP &&
			plat_config_data->m_u32Arm_type != MX6Q &&
			plat_config_data->m_u32Arm_type != MX6DL &&
			plat_config_data->m_u32Arm_type != MX6 &&
			plat_config_data->m_u32Arm_type != MX50 &&
			miu->writesize + miu->oobsize != 2048 + 64 &&
			miu->writesize + miu->oobsize != 4096 + 128 &&
			miu->writesize + miu->oobsize != 4096 + 224 &&
			miu->writesize + miu->oobsize != 4096 + 218 &&
			miu->writesize + miu->oobsize != 8192 + 376 &&
			miu->writesize + miu->oobsize != 8192 + 512) {
			fprintf(stderr, "mtd: device %s; unsupported geometry (%d/%d)\n",
					mp->name, miu->writesize, miu->oobsize);
			goto out;
		}

https://github.com/NXPmicro/imx-kobs/blob/master/src/mtd.c#L987

For me this looks broken - it accepts every geometry as long as the soc is supported?

rhubert avatar Jan 07 '21 12:01 rhubert