NVIDIAGameWorks
Fix/msvc compilation
This PR fixes two issues with compilation on Windows using MSVC.
- forward declaration inconsistency with the actual definition of the cuda function
MeshIntersectionKernelLauncher - fix of preprocessor condition syntax that was not working properly on MSVC
With these two fixes, I was able to compile on Windows just fine, the setup was the following: Python version: 3.6 CUDA version: 10.1 Pytorch version: 1.4.0
Hi @coloss ,
Thank you for your interest in Kaolin!
Can you signoff your first commit ? (you can use git rebase -i -S).
Hi @Caenorst . Did that do it? I've actually never had to do that before so I'm not sure if I did it right.
The two commits doesn't seems to be signed properly.
your second commit is actually signed but with a GPG-key which apparently removed the signature ?
you can look at https://github.com/NVIDIAGameWorks/kaolin/pull/200/checks?check_run_id=588333880 for status
Basically at the end of all your commits messages there should be:
Signed-off-by: your_github_username <your_email_address>
I believe the email address should one of those linked to you github account.
Hi @coloss your PR looks good to me, but we can't merge it until the commits are passing our DCO bot. Signoff your commits as recommended above ?
@Caenorst , sorry for the delay. I forgot about this. I did add the changes. Is it fine like this?
@coloss The checks seem to have failed.
The first of them is easy to fix (signoff on all your commits; for convenience, see instructions here https://github.com/NVIDIAGameWorks/kaolin/pull/200/checks?check_run_id=632291095)
The second issue seems to be with compiling the library; do you already know that error?
Note the subtle issus in the signoff. It seems you signed off, but using different creds (likely cause you were on a different machine?)
Expected "Radek Danecek [email protected]", but got "coloss [email protected]".
