kaolin-wisp icon indicating copy to clipboard operation
kaolin-wisp copied to clipboard

includes warping that works in 2d setting

Open svsambandam opened this issue 1 year ago • 4 comments

svsambandam avatar Mar 23 '23 00:03 svsambandam

yay! it also includes hashnerf-pytorch :)

svsambandam avatar Mar 23 '23 00:03 svsambandam

Hi @svsambandam , thanks a lot for sharing this one! :) Is this still work in progress?

From quickly browsing through we would need:

  1. To clean up some of the redundant code (i.e. _raymarch_2d, debug prints, etc)
  2. A little example of how to run + expected output

orperel avatar Mar 23 '23 18:03 orperel

Hello!

Apologies, that was an accidental commit! I was unsure how to undo it! It's still very much a work in progress haha. Sorry for the inconvenience!

Best, Sneha

On Thu, Mar 23, 2023 at 11:40 AM Or Perel @.***> wrote:

Hi @svsambandam https://github.com/svsambandam , thanks a lot for sharing this one! :) Is this still work in progress?

From quickly browsing through we would need:

  1. To clean up some of the redundant code (i.e. _raymarch_2d, debug prints, etc)
  2. A little example of how to run + expected output

— Reply to this email directly, view it on GitHub https://github.com/NVIDIAGameWorks/kaolin-wisp/pull/134#issuecomment-1481713938, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPJFMC3NCYA2KMOZXBB2SDW5SKIRANCNFSM6AAAAAAWEP3QKY . You are receiving this because you were mentioned.Message ID: @.***>

svsambandam avatar Mar 23 '23 18:03 svsambandam

No worries! We're squashing everything before we merge it anyway. Feel free to post as many commits needed, just let me know when this is ready to review & push

orperel avatar Mar 23 '23 18:03 orperel