Streamline_Sample icon indicating copy to clipboard operation
Streamline_Sample copied to clipboard

Docs out of date for NRD integration, and no reference NRD implementation exists either

Open BattleAxeVR opened this issue 1 year ago • 3 comments

Hi there, I'm switching from my old (outdated) NRD integration because it changes too often and is way too much maintenance overhead, so I figured SL would help me out here, but the docs for NRD use deprecated API features and there's no clear way to actually set the NRD constants via a function stub, like there are for the other features.

https://github.com/NVIDIAGameWorks/Streamline/blob/main/docs/ProgrammingGuideNRD.md

Specifically slSetFeatureConstants is gone now in 2.10:

image

I implemented setting the NRD specific constants like this:

image

image

image

Is this correct? I read all the docs and it seems to be the way to do it, but it's odd that there's no function stub in the sl.nrd.h for the function call to set the parameters.

My code seems to set the parameters properly, but then I get some weird exception when I do the actual denoising:

image

Is there a chance you would consider making an NRD integration in the sample here? It's the only feature missing a reference implementation.

The Path Tracing SDK also uses StreamLine but has a direct NRD integration and I haven't been able to find anything on Github where NRD is integrated via SL as opposed to directly.

Is anybody out there using SL for NRD feature but me? It seems not. I searched in Github for sl::kFeatureNRD and the only hits are in this repo.

Thanks in advance!

BattleAxeVR avatar Jul 11 '23 22:07 BattleAxeVR