Missing const for uint32_t* frameIndex in PFun_slGetNewFrameToken

Open QDanteQ opened this issue 1 year ago • 2 comments

Hello, I guess you've missed const specifier for uint32_t* frameIndex. There's const in function declaration (down the file) and in implementation. https://github.com/NVIDIAGameWorks/Streamline/blob/7ac42e47c7dd55b5b6dd6176c0228048636541b2/include/sl.h#L660

Mar 15 '24 16:03 QDanteQ

Nice catch.

This won’t be in the upcoming release, but it will be in the one after.

Mar 20 '24 04:03 jake-nv

We haven’t forgotten about this. This wasn’t in 2.4.10 because it was done after a re-org of sl.h that now can’t be cherry-picked into 2.4.x. It’ll go in with the next mass-integration (likely 2.5 or the equivalent).

Jun 05 '24 15:06 jake-nv