Failed to compile with visual studio 2019

[gobaya111]

class RtShader is privately inherited form the inherit_shared_from_this class. The code failed to be compiled in Visual studio, with the following error message: D:\Falcor-master\Source\Falcor\Core\Framework.h(231,1): error C2243: 'static_cast': conversion from 'const Falcor::inherit_shared_from_thisFalcor::Program,Falcor::ComputeProgram *' to 'const Derived *' exists, but is inaccessible This issue can be fixed by change the inheritance to public: class dlldecl RtShader : public Shader, public inherit_shared_from_this<Shader, RtShader>. The same issues in other class can be fixed in the same way.

[FishOrBear]

yep,Seems to have other problems

严重性 代码 说明 项目 文件 行 禁止显示状态 错误 C2678 二进制“==”: 没有找到接受“Falcor::D3D12DescriptorHeap::Allocation::SharedPtr”类型的左操作数的运算符(或没有可接受的转换) Falcor D:\Dev\Falcor-4.0-preview\Source\Falcor\Core\API\D3D12\D3D12DescriptorSet.cpp 67