warp icon indicating copy to clipboard operation
warp copied to clipboard

[REQUEST] Add atomic_max and atomic_min for float64

Open swan2818 opened this issue 1 year ago • 5 comments

Description

For now, the atomic_max and atomic_min operators in Warp are for float and int only.

Context

Please support float64 for the atomic_max and atomic_min operators.

swan2818 avatar Jul 31 '24 23:07 swan2818

Hi @swan2818 @shi-eric I went through this issue and looking to contribute here I was hoping if this is an priority task and I could take it up as my good-first-issue? Lmk if there's something else I can work upon, thanks!

Irene-123 avatar Aug 11 '24 08:08 Irene-123

Hi @Irene-123, thanks for volunteering! I think @daedalus5 might already be working on this issue. The other two you expressed an interest in should be open for you to take up.

shi-eric avatar Aug 11 '24 16:08 shi-eric

That's great, thank you @shi-eric Is there a discord channel to have a discussion?

Irene-123 avatar Aug 11 '24 17:08 Irene-123

That's great, thank you @shi-eric Is there a discord channel to have a discussion?

Yes, there is a channel for Warp in the Omniverse Discord server (link)

shi-eric avatar Aug 11 '24 17:08 shi-eric

Yes I have an MR in for this now.

daedalus5 avatar Aug 12 '24 19:08 daedalus5