thrust icon indicating copy to clipboard operation
thrust copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA

Fix RDC flags on nvc++ builds.

Open alliepiper opened this issue 2 years ago • 5 comments

nvcc defaults to rdc-off, nvc++ defaults to rdc-on. We need to explicitly enable or disable these flags for each CUDA target, rather than just enabling them when needed.

alliepiper avatar Jul 21 '22 17:07 alliepiper

run tests

alliepiper avatar Jul 21 '22 17:07 alliepiper

I understand the problem and agree with the goal of this. But I don't know CMake well enough to review the actual changes in any useful way.

dkolsen-pgi avatar Jul 21 '22 23:07 dkolsen-pgi

run tests

alliepiper avatar Jul 22 '22 16:07 alliepiper

Looks like this change exposed some bugs in nvc++ now that some translation units turn RDC off. I'll aim to reduce these and file some bug reports next week.

alliepiper avatar Jul 22 '22 23:07 alliepiper

@miscco is looking into the nvc++ failures.

alliepiper avatar Aug 04 '22 18:08 alliepiper

This will no longer be needed after an upcoming CMake refactoring.

alliepiper avatar Mar 10 '23 14:03 alliepiper