spark-rapids icon indicating copy to clipboard operation
spark-rapids copied to clipboard

Added Shims for adding Databricks 14.3 Support [databricks]

Open razajafri opened this issue 1 year ago • 1 comments

This PR adds Shims for Databricks 14.3

razajafri avatar Oct 18 '24 23:10 razajafri

build

razajafri avatar Oct 21 '24 17:10 razajafri

@gerashegalov @mythrocks PTAL

razajafri avatar Oct 28 '24 20:10 razajafri

Please update Scala 2.13 poms

gerashegalov avatar Oct 31 '24 06:10 gerashegalov

@gerashegalov I have addressed your concerns. PTAL

razajafri avatar Oct 31 '24 21:10 razajafri

Re failing package-tests (350db143, false) , need to make sure that the db buildvers are not included in the Github Workflow build matrix

gerashegalov avatar Nov 04 '24 22:11 gerashegalov

Re failing package-tests (350db143, false) , need to make sure that the db buildvers are not included in the Github Workflow build matrix

Hang on, I will have to modify the workflow file and remove the change from pom.xml

razajafri avatar Nov 05 '24 18:11 razajafri

build

gerashegalov avatar Nov 06 '24 07:11 gerashegalov

build

razajafri avatar Nov 07 '24 00:11 razajafri

It's looking good to go, now that the build is passing as well, no?

mythrocks avatar Nov 07 '24 07:11 mythrocks

@razajafri Can you enable Databricks-14.3 in the pre-merge CI pipeline in this PR as below?

https://github.com/NVIDIA/spark-rapids/blob/branch-24.12/jenkins/Jenkinsfile-blossom.premerge-databricks#L94

values '11.3', '12.2', '13.3', '14.3'

NvTimLiu avatar Nov 07 '24 15:11 NvTimLiu

build

razajafri avatar Nov 07 '24 17:11 razajafri

@razajafri Can you enable Databricks-14.3 in the pre-merge CI pipeline in this PR as below?

https://github.com/NVIDIA/spark-rapids/blob/branch-24.12/jenkins/Jenkinsfile-blossom.premerge-databricks#L94

values '11.3', '12.2', '13.3', '14.3'

I have updated it but this will turn the integration tests on. We don't want the integration tests to run against Databricks 14.3 because we aren't ready.

razajafri avatar Nov 07 '24 23:11 razajafri

build

razajafri avatar Nov 08 '24 16:11 razajafri

build

razajafri avatar Nov 08 '24 18:11 razajafri

build

AWS_INSUFFICIENT_INSTANCE_CAPACITY_FAILURE

razajafri avatar Nov 08 '24 18:11 razajafri

build

razajafri avatar Nov 08 '24 23:11 razajafri

build

pxLi avatar Nov 11 '24 05:11 pxLi

build

AWS_INSUFFICIENT_INSTANCE_CAPACITY_FAILURE

This change requires 8 clusters (4 shims x 2 parallelism) for the CI. We're considering using some escalation strategy, such as switching to different instance types or cloud providers or temporarily disabling parallel runs for Databricks runtimes.

also cc @NvTimLiu

BTW my last trigger works fine

pxLi avatar Nov 11 '24 05:11 pxLi