physicsnemo
physicsnemo copied to clipboard
Fixes for test collection and guards for missing PhysicsNeMo-Sym
PhysicsNeMo Pull Request
Description
Addresses two bugs:
- Previously, running
pytest .from root caused an error in test collection due to path issues intest_runner.py. Fixed this, and refactored to use the more-modernpathlibbuiltin library instead ofos.path. (In general, going forward, we should typically preferpathliboveros.path) - There was (and still is) a bug that one of the docs-folder test scripts in the PhysicsNeMo repo depends on PhysicsNeMo-Sym. This fails on a vanilla PhysicsNeMo install, as Sym is not included. My current understanding is that the PhysicsNeMo -> PhysicsNeMo Sym dependency was intended to be only one-way: sym depends on core, but core does not depend on sym.
This provides a fix for the first bug, and at least a more graceful failure for the second bug.
Checklist
- [x] I am familiar with the Contributing Guidelines.
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
- [x] The CHANGELOG.md is up to date with these changes.
- [ ] An issue is linked to this pull request.
Dependencies
/blossom-ci
/blossom-ci
/blossom-ci