physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard
Published 4 days ago • verified publisher icon NVIDIA

Add HydroGraphNet model and example to PhysicsNeMo

Open MehdiTaghizadehUVa opened this issue 7 months ago • 1 comments

PhysicsNeMo Pull Request

Description

Checklist

  • [ ] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [ ] The documentation is up to date with these changes.
  • [ ] The CHANGELOG.md is up to date with these changes.
  • [ ] An issue is linked to this pull request.

Dependencies

MehdiTaghizadehUVa avatar May 08 '25 21:05 MehdiTaghizadehUVa

Hi @mnabian, Thank you for the feedback. I’ve addressed the comments as follows:

Moved sample_animation.gif to docs/img

Removed all functions using pickle due to security concerns

Removed the duplicate import of KolmogorovArnoldNetwork

Please let me know if any further changes are needed.

MehdiTaghizadehUVa avatar May 12 '25 17:05 MehdiTaghizadehUVa

/blossom-ci

mnabian avatar May 20 '25 00:05 mnabian

Thanks @MehdiTaghizadehUVa ! Could you please also add unit tests for the datapipe, model, and the KAN layer?

mnabian avatar May 20 '25 00:05 mnabian

/blossom-ci

mnabian avatar May 20 '25 18:05 mnabian

/blossom-ci

mnabian avatar May 20 '25 20:05 mnabian

/blossom-ci

mnabian avatar May 20 '25 20:05 mnabian

/blossom-ci

mnabian avatar May 20 '25 22:05 mnabian

/blossom-ci

mnabian avatar May 21 '25 00:05 mnabian

/blossom-ci

mnabian avatar May 21 '25 01:05 mnabian

/blossom-ci

mnabian avatar May 21 '25 02:05 mnabian

Hi Mohammad,

Thanks for fixing a couple of issues in the code and test files. I’ve now addressed the remaining errors, and everything should be working fine.

Best, Mehdi

MehdiTaghizadehUVa avatar May 21 '25 06:05 MehdiTaghizadehUVa

/blossom-ci

mnabian avatar May 21 '25 17:05 mnabian

/blossom-ci

mnabian avatar May 21 '25 17:05 mnabian

/blossom-ci

mnabian avatar May 21 '25 18:05 mnabian