physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard
Published 4 days ago • verified publisher icon NVIDIA

removing figconv directory from examples/cfd/

Open RishikeshRanade opened this issue 10 months ago • 1 comments

Modulus Pull Request

Description

Checklist

  • [ ] I am familiar with the Contributing Guidelines.
  • [ ] New or existing tests cover these changes.
  • [ ] The documentation is up to date with these changes.
  • [ ] The CHANGELOG.md is up to date with these changes.
  • [ ] An issue is linked to this pull request.

Dependencies

RishikeshRanade avatar Jan 28 '25 14:01 RishikeshRanade

/blossom-ci

Alexey-Kamenev avatar Jan 28 '25 16:01 Alexey-Kamenev

@RishikeshRanade @Alexey-Kamenev is this PR stale, now that it looks like examples/cfd has a working FigConvNet example? If so, can we safely close this PR?

peterdsharpe avatar Jun 19 '25 18:06 peterdsharpe

Yes - good catch, I forgot to close this PR. The reason we had it was issues with Blossom which would not allow PRs with file deletions. That issue was eventually fixed and my other PR went through.

Alexey-Kamenev avatar Jun 19 '25 21:06 Alexey-Kamenev