physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard

fix dlwp_healpix constant coupler batch inference

Open ivanauyeung opened this issue 1 year ago • 4 comments

Modulus Pull Request

Description

Fix the bug where dlwp_healpix constant coupler did not support batch coupled inputs for inference

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.
  • [x] The CHANGELOG.md is up to date with these changes.
  • [ ] An issue is linked to this pull request.

Dependencies

ivanauyeung avatar Sep 25 '24 02:09 ivanauyeung

What test covers this change?

dallasfoster avatar Sep 25 '24 08:09 dallasfoster

@ivanauyeung
I tested successfully the inference of ensemble forecast with this PR. However, do we know this works in training? have you tested that?

yairchn avatar Sep 25 '24 20:09 yairchn

The function set_coupled_fields in the coupler.py is only used in the inference stage. So these changes will not affect the training. Also, tests are added to cover this function.

ivanauyeung avatar Sep 29 '24 04:09 ivanauyeung

/blossom-ci

daviddpruitt avatar Dec 05 '24 19:12 daviddpruitt