physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard

Add Transolver model

Open luohk19 opened this issue 1 year ago • 5 comments

Modulus Pull Request

Description

  • Add transolver model from ICML 2024.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.
  • [x] The CHANGELOG.md is up to date with these changes.
  • [x] An issue is linked to this pull request.

Dependencies

  • einops 0.8.0

luohk19 avatar Jul 15 '24 09:07 luohk19

Reference paper: https://arxiv.org/pdf/2402.02366

mnabian avatar Jul 16 '24 01:07 mnabian

Hi @luohk19 , thanks for your contribution! Have you verified that your implementation reproduces the paper results? If so, could you please post some results here for reference?

mnabian avatar Jul 16 '24 01:07 mnabian

Hi @luohk19 , thanks for your contribution! Have you verified that your implementation reproduces the paper results? If so, could you please post some results here for reference?

I've discovered some mismatches in problem setting between modulus's darcy and transolver's. In modulus, each batch is a new data simulated by algorithm. But in transolver's setting, training set and test set are fixed. So I fixes the process of generation and successfully reproduces the paper results as follows.

And I've also added the reproduction code to the commit.

截屏2024-08-15 19 40 56

截屏2024-08-15 19 17 40

luohk19 avatar Aug 15 '24 11:08 luohk19

Please add unit tests for your datapipe and model, change the license headers and add exceptions, and update the readme to descripe the difference between two training recipes, how to validate the model, and include a plot for the results.

mnabian avatar Sep 26 '24 00:09 mnabian

Please add unit tests for your datapipe and model, change the license headers and add exceptions, and update the readme to descripe the difference between two training recipes, how to validate the model, and include a plot for the results.

I've added unit tests for new datapipe and the transolver, changed the license headers in transolver, and added more details in readme with a plot and a link to the dataset.

luohk19 avatar Oct 09 '24 09:10 luohk19

/blossom-ci

mnabian avatar Oct 12 '24 00:10 mnabian

/blossom-ci

mnabian avatar Oct 14 '24 20:10 mnabian

/blossom-ci

mnabian avatar Oct 16 '24 22:10 mnabian

/blossom-ci

mnabian avatar Oct 17 '24 00:10 mnabian

/blossom-ci

mnabian avatar Oct 17 '24 00:10 mnabian

/blossom-ci

mnabian avatar Oct 17 '24 00:10 mnabian

/blossom-ci

mnabian avatar Oct 17 '24 01:10 mnabian

/blossom-ci

mnabian avatar Oct 17 '24 17:10 mnabian