physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard

Update dali dependency to a cuda 12 compatible version

Open ktangsali opened this issue 1 year ago • 1 comments

Modulus Pull Request

Description

Closes https://github.com/NVIDIA/modulus/issues/493

Tested the change by executing pytests in a blank conda environment with modulus source install.

The Modulus container was already using a CUDA 12 compatible Dali version so no changes required to the Dockerfile.

Checklist

  • [x] I am familiar with the Contributing Guidelines.
  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.
  • [x] The CHANGELOG.md is up to date with these changes.
  • [x] An issue is linked to this pull request.

Dependencies

ktangsali avatar May 17 '24 17:05 ktangsali

/blossom-ci

ktangsali avatar May 17 '24 17:05 ktangsali

Looks good to me, I think this one is a no-brainer. Any objections?

azrael417 avatar May 21 '24 05:05 azrael417

/blossom-ci

NickGeneva avatar May 21 '24 05:05 NickGeneva