[CorrDiff]: Refactor CorrDiff configs to use dataclass attributes
Modulus Pull Request
Description
This PR exchanges the getattr calls with @dataclass attributes, instantiated with Hydra.
Relevant issue: #417
Checklist
- [x] I am familiar with the Contributing Guidelines.
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
- [ ] The CHANGELOG.md is up to date with these changes.
- [x] An issue is linked to this pull request.
Dependencies
N/A
@mnabian - not sure whether I should add the changes to the CHANGELOG.md, being just a small refactor. Perhaps after review? :)
@mnabian gentle ping - any other changes required for the refactor?
Hi @DavidLandup0 , thanks for your PR! We will merge this PR soon closer to the Modulus release in June.
Hi @DavidLandup0 , we have made extensive changes to the CorrDiff code and also refactored the configs. Unfortunately, your changes are not consistent with the way configs are currently handled, and we have to close this PR. We really appreciate your contribution and look forward to your future contributions!