physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard

🚀[FEA]: Add line length checks back in to the ruff config

Open akshaysubr opened this issue 2 years ago • 0 comments

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Line length checks in a linter are really useful and help lessen the number of pre-commit errors with black. But currently many files fail this test, so https://github.com/NVIDIA/modulus/pull/171 leaves these checks out. It would be good to add them back in as part of a new PR.

Describe any alternatives you have considered

See how pandas enforces consistency between black and ruff: https://github.com/pandas-dev/pandas/blob/main/pyproject.toml#L210

akshaysubr avatar Sep 25 '23 22:09 akshaysubr