physicsnemo icon indicating copy to clipboard operation
physicsnemo copied to clipboard

🚀[FEA]: Should include multi GPU tests in CI coverage

Open akshaysubr opened this issue 2 years ago • 1 comments

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem you would like to solve.

Currently, there is a pytest fixture to mark tests as multi-GPU which allows us to write distributed tests. But these are not actually run in CI and so code coverage of these tests is not accounted for. Ideally, CI would support multi-GPU tests and would merge coverage reports of the single and multi GPU tests.

Describe any alternatives you have considered

None

akshaysubr avatar Sep 21 '23 05:09 akshaysubr

Relates to issue: https://github.com/NVIDIA/modulus/issues/74

akshaysubr avatar Sep 21 '23 05:09 akshaysubr

@ktangsali I believe CI now supports multi-GPU tests? Can we close as completed?

mnabian avatar Oct 18 '24 01:10 mnabian

Multi-GPU CI can be currently run on-demand (using multi-gpu-ci). However we are yet to integrate them in the coverage report. Considering shortage of CI hardware, I don't think we can enable that just yet.

ktangsali avatar Oct 18 '24 13:10 ktangsali