nvbench icon indicating copy to clipboard operation
nvbench copied to clipboard

Make nvbench targets use SYSTEM includes

Open cliffburdick opened this issue 4 years ago • 2 comments

When using nvbench::main in a target, nvbench adds an include path for nvbench using -I instead of -isystem. This causes tools like clang-tidy to pick up nvbench as outside of the system scope, and subsequently all the dependencies of nvbench are picked up too (libfmt, for example).

cliffburdick avatar Sep 14 '21 20:09 cliffburdick

#42 will get us part of the way there, by adding the ability to do find_package(NVBench) and produce proper imported targets, which will provide system includes by default.

Additional work is needed for add_subdirectory, and I need to check which method will be used by things like CPM.

alliepiper avatar Oct 19 '21 22:10 alliepiper