nv-ingest icon indicating copy to clipboard operation
nv-ingest copied to clipboard

[FEA]: Remove yolox postprocessing duplicate code

Open edknv opened this issue 1 year ago • 1 comments

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Would be nice

Please provide a clear description of problem this feature solves

postprocess_model_prediction and postprocess_results are duplicated in YOLOX NIM codebase. These functions should be removed from nv-ingest.

expand_chart_bboxes and the thresholding is logic that is specific to nv-ingest. These should be kept on the nv-ingest side.

Describe the feature, and optionally a solution or implementation and any alternatives

  • The HTTP endpoint of YOLOX NIM returns an output with postprocess_model_prediction and postprocess_results, so we need to switch to using the HTTP endpoint.
  • The fix for chart bounding box issues is not yet available in nv-yolox-structured-images-v1:0.1.0 but will be available in 0.2.0. Switch to the new release when it becomes availble.
  • Verify that there is no performance regression with the switch.
  • See discussion in internal slack thread (ping @edknv if you cannot locate the thread).

Additional context

No response

edknv avatar Sep 27 '24 18:09 edknv

Moved to Blocked status. Recent performance testing showed that the HTTP endpoints of YOLOX/PaddleOCR/cached cannot withstand a heavy load. We cannot switch to HTTP endpoinits unless load tests show HTTP endpoints has the samel level of performance as GRPC Triton endpoints.

edknv avatar Oct 24 '24 18:10 edknv

Closed by https://github.com/NVIDIA/nv-ingest/pull/332

edknv avatar Feb 05 '25 03:02 edknv