modulus icon indicating copy to clipboard operation
modulus copied to clipboard

🐛[BUG]: `EDMLossSR` not imported at `modulus/metrics/diffusion/__init__.py`

Open stathius opened this issue 8 months ago • 0 comments

Version

0.7.0a

On which installation method(s) does this occur?

Docker, Source

Describe the issue

Analysis: modulus/modulus/metrics/diffusion/__init__.py does not importe the EDMLossSR is that intentional.

Proposed fix: Add EDMLossSR to the imports.

Minimum reproducible example

python3 train.py --config-name=config_train_diffusion.yaml
config: 
     arch: ddpmpp-cwb
     precond: edmv1
     task: diffusion

Relevant log output

Traceback (most recent call last):
  File "/code/modulus/examples/generative/corrdiff/train.py", line 344, in main
    training_loop.training_loop(
  File "/code/modulus/examples/generative/corrdiff/training/training_loop.py", line 190, in training_loop   <--------------
    loss_fn = construct_class_by_name(**loss_kwargs, **interface_kwargs)
  File "/code/modulus/modulus/utils/generative/utils.py", line 306, in construct_class_by_name
    return call_func_by_name(*args, func_name=class_name, **kwargs)
  File "/code/modulus/modulus/utils/generative/utils.py", line 293, in call_func_by_name
    func_obj = get_obj_by_name(func_name)
  File "/code/modulus/modulus/utils/generative/utils.py", line 281, in get_obj_by_name
    module, obj_name = get_module_from_obj_name(name)
  File "/code/modulus/modulus/utils/generative/utils.py", line 255, in get_module_from_obj_name
    get_obj_from_module(module, local_obj_name)  # may raise AttributeError
  File "/code/modulus/modulus/utils/generative/utils.py", line 273, in get_obj_from_module
    obj = getattr(obj, part)
AttributeError: module 'modulus.metrics.diffusion' has no attribute 'EDMLossSR'

Environment details

python version: 3.10
modulus commit: `c07fa25321c48a1d71efca12b67d056adbca8bd4`

stathius avatar May 30 '24 23:05 stathius