libcudacxx icon indicating copy to clipboard operation
libcudacxx copied to clipboard
verified publisher icon NVIDIA

Do not move arrival_token in barrier::try_wait

Open ahendriksen opened this issue 2 years ago • 3 comments

Take a mutable reference instead.

Moving the token into try_wait makes no sense. The caller has to be able to retry the try wait with the same token.

For more details and C++ spec, see:

https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2643r1.html

ahendriksen avatar Jul 27 '23 15:07 ahendriksen

Hi @ahendriksen

Could you please reopen the PR against our new monorepo https://github.com/NVIDIA/cccl

miscco avatar Jul 27 '23 19:07 miscco

I have moved the PR to https://github.com/NVIDIA/cccl/pull/283

What is the status of this repository? Are some or all pull requests redirected to cccl? I thought I might have overlooked some documentation, but the contributing guide tells me to open a PR?

ahendriksen avatar Jul 28 '23 07:07 ahendriksen

What is the status of this repository? Are some or all pull requests redirected to cccl? I thought I might have overlooked some documentation, but the contributing guide tells me to open a PR?

The status is the unfortunate "in transition"

We are almost done setting everything up with cccl, so that this repo will be archived afaik

miscco avatar Jul 28 '23 09:07 miscco