libcudacxx icon indicating copy to clipboard operation
libcudacxx copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA

Rename `.upstream-tests`

Open brycelelbach opened this issue 3 years ago • 2 comments

Especially after the refactoring away from submodules, I find the name of this directory very confusing; the upstream tests (e.g. raw libc++ tests) live in libcxx/test, not .upstream-tests.

brycelelbach avatar Sep 18 '20 03:09 brycelelbach

I'm planning to do away with the subdirectory entirely and just promote the symlinks to be the actual directories inside .upstream-tests.

griwes avatar Sep 18 '20 06:09 griwes

Also if I remember my reasoning back when it was added, there was some kind of an expectation that we'd have some CUDA-specific tests outside of the libc++ test framework, so the name isn't "tests of the upstream", it's "tests that come from the upstream". But I agree that in hindsight, it's not the best name imaginable ;)

griwes avatar Sep 18 '20 07:09 griwes