libcudacxx icon indicating copy to clipboard operation
libcudacxx copied to clipboard

Add docker files for 16 configs

Open veictry opened this issue 2 years ago • 6 comments

Config

  • Arch: x86_64
  • Compiler: HPC | GCC 11 | NVRTC

DVSSC Virtual:

  • HPC: https://scbuilds4u/dvs/#/change/3116046839432407.1?eventType=Virtual
  • GCC 11: https://scbuilds4u/dvs/#/change/3116077939432407.2?eventType=Virtual
  • NVRTC: http://scbuilds4u.nvidia.com/dvs/#/change/3116084339432407.1?showTab=DVS (failed with libcudacxx issue)

veictry avatar Apr 04 '22 08:04 veictry

I have one complaint: We don't target platforms for testing; we target compilers. So if Ubuntu+GCC11 already cover a test we don't need fedora+GCC11.

Would it be possible to remove overlaps?

wmaxey avatar Apr 04 '22 17:04 wmaxey

Hi @wmaxey I don't find GCC 11 docker file in docker/host_x86_64/... is there something I missed?

veictry avatar Apr 05 '22 02:04 veictry

I submitted other docker files in one commit. please help review them.

all DVS-SC build:

Arch Compiler Link Status
x86_64 GCC 11 https://scbuilds4u/dvs/#/change/3115976339432407.1?eventType=Virtual OK
x86_64 HPC http://scbuilds4u.nvidia.com/dvs/#/change/3116788639432407.2?showTab=DVS OK
x86_64 NVRTC http://scbuilds4u.nvidia.com/dvs/#/change/3116681639432407.3?showTab=DVS OK
arm64 GCC 8 http://scbuilds4u.nvidia.com/dvs/#/change/3116830139432407.3?showTab=DVS  
arm64 HPC http://scbuilds4u.nvidia.com/dvs/#/change/3117049939432407.1?showTab=DVS  
arm64 NVRTC http://scbuilds4u.nvidia.com/dvs/#/change/3116796739432407.1?showTab=DVS OK
arm64 Clang 12 http://scbuilds4u.nvidia.com/dvs/#/change/3116683539432407.1?showTab=DVS OK
arm64 Clang 13 http://scbuilds4u.nvidia.com/dvs/#/change/3116683539432407.1?showTab=DVS OK
arm64 armclang http://scbuilds4u.nvidia.com/dvs/#/change/3116695539432407.1?showTab=DVS OK
arm64 armgcc http://scbuilds4u.nvidia.com/dvs/#/change/3116695539432407.1?showTab=DVS OK
ppc64le GCC 8 http://scbuilds4u.nvidia.com/dvs/#/change/3116632539432407.1?showTab=DVS OK
ppc64le Clang 12 http://scbuilds4u.nvidia.com/dvs/#/change/3116632539432407.1?showTab=DVS OK
ppc64le HPC http://scbuilds4u.nvidia.com/dvs/#/change/3116762839432407.2?showTab=DVS OK
x86_64 GCC 11 C++20 http://scbuilds4u.nvidia.com/dvs/#/change/3116715139432407.1?showTab=DVS OK
x86_64 Clang 14 http://scbuilds4u.nvidia.com/dvs/#/change/3116837439432407.1?showTab=DVS OK
x86_64 MSVC http://scbuilds4u.nvidia.com/dvs/#/change/3116523939432407.1?showTab=DVS OK

veictry avatar Apr 06 '22 04:04 veictry

There have been a few changes to the Dockerfiles recently that will effect these, but I have some scripts I previously used to make those changes. I've replicated them here.

ADD cuda/tools/libcudacxxext /sw/gpgpu/cuda/tools/libcudacxxext has been removed. We own the files in this directory now. Additionally other CUDART headers have been packaged along with compiler, I believe we can remove those.

# Remove comment from section of dockerfile.
sed -i "\#.*Copy the core CUDA#d" $(find docker -iname "*dockerfile")
# Remove various sw/gpgpu files from dockerfile.
sed -i "\#ADD cuda/.* /sw/gpgpu/cuda/.*#d" $(find docker -iname "*dockerfile")
sed -i "\#ADD opencl/*#d" $(find docker -iname "*dockerfile")
sed -i "\#ADD cuda/tools/libcudacxxext /sw/gpgpu/cuda/tools/libcudacxxext#d" $(find docker -iname "*dockerfile")

wmaxey avatar Apr 15 '22 00:04 wmaxey

Hi @wmaxey I don't find GCC 11 docker file in docker/host_x86_64/... is there something I missed?

My apologies, I hadn't realized it wasn't already covered.

wmaxey avatar Apr 15 '22 00:04 wmaxey

These changes overall look good, I'll approve once the fixes I suggested are applied to this PR.

wmaxey avatar Apr 15 '22 00:04 wmaxey

@wmaxey Do we still want this given the recent docker rework?

miscco avatar Feb 21 '23 09:02 miscco

I don't think so. If there's a need @veictry or @chengjiew can DM me and we can look at adding them.

wmaxey avatar Feb 22 '23 02:02 wmaxey