libcudacxx icon indicating copy to clipboard operation
libcudacxx copied to clipboard

Added support for most of <mutex>

Open ogiroux opened this issue 4 years ago • 2 comments
trafficstars

Has mutex, timed_mutex, once_flag, call_once, unique_lock, scoped_lock, and varied free functions that go with them. Excludes only condition variable support and the recursive versions of mutex.

ogiroux avatar Feb 02 '21 19:02 ogiroux

TODO: Test ports and heterogeneous tests.

wmaxey avatar Feb 03 '21 19:02 wmaxey

@wmaxey @ogiroux is this just waiting on porting tests? I'd like to move forward with exploring https://github.com/NVIDIA/cccl/issues/990, but it depends on having a mutex first.

jrhemstad avatar Jan 27 '22 03:01 jrhemstad

@jrhemstad How important is this and should I try to get this rebased?

miscco avatar Feb 23 '23 12:02 miscco

@jrhemstad How important is this and should I try to get this rebased?

It's important, but not urgent. No need to try and get it merged before the next release. There is still a sizable amount of work to add tests before it can be merged anyways.

jrhemstad avatar Feb 23 '23 15:02 jrhemstad

While everything works fine locally, this PR is incredibly flaky in CI.

We need to investigate why that is the case and find a strategy to unflake it

miscco avatar Mar 30 '23 12:03 miscco

Dropping in favor of https://github.com/NVIDIA/cccl/pull/187

miscco avatar Jul 10 '23 15:07 miscco