gpu-operator icon indicating copy to clipboard operation
gpu-operator copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA

changes to allow custom labels for ServiceMonitor

Open csauoss opened this issue 1 year ago • 2 comments

This pr addresses issue 710 to allow passing custom labels for gpu-operator's ServiceMonitor.

csauoss avatar Jul 18 '24 18:07 csauoss

changes look good, @csauoss can you rebase please.

shivamerla avatar Sep 06 '24 18:09 shivamerla

changes look good, @csauoss can you rebase please.

@shivamerla Thanks for taking a look. pulled in changes from main and did the rebase.

csauoss avatar Sep 07 '24 08:09 csauoss

@shivamerla can you please review it again when you get a chance? thanks!

csauoss avatar Oct 27 '24 20:10 csauoss

@csauoss @shivamerla It would be great to see this land, any updates on getting this into main?

ramesius avatar Apr 29 '25 06:04 ramesius

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar May 18 '25 00:05 copy-pr-bot[bot]

@ramesius thanks for bumping this. I have rebased it and is ready for review again. Hoping for @shivamerla @cdesiniotis to take a look when they get a chance.

csauoss avatar May 18 '25 00:05 csauoss