gpu-operator icon indicating copy to clipboard operation
gpu-operator copied to clipboard

Support the `DevicePluginCDIDevices` feature gate

Open jfroy opened this issue 1 year ago • 1 comments

This patch adds support for the DevicePluginCDIDevices feature gate by adding spec.operator.useDevicePluginCDIDevicesFeature to ClusterPolicy. When this field is set, the operator sets the DEVICE_LIST_STRATEGY device plug-in environment variable to cdi-cri.

jfroy avatar Sep 23 '24 14:09 jfroy

@cdesiniotis @elezar

jfroy avatar Sep 23 '24 17:09 jfroy

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 06 '24 22:11 copy-pr-bot[bot]

@cdesiniotis I imagine https://github.com/NVIDIA/gpu-operator/pull/1285 obsoletes this PR?

jfroy avatar Feb 19 '25 23:02 jfroy

@cdesiniotis I imagine #1285 obsoletes this PR?

Ah wait, no, it doesn't use "native CDI" but instead relies on annotations. I'll comment more in the internal document about this.

jfroy avatar Feb 19 '25 23:02 jfroy

@jfroy I've updated #1285 to use the CRI instead of annotations, so yes, if we proceed with #1285 it will obsolete this PR. See the discussion here: https://github.com/NVIDIA/gpu-operator/pull/1285#discussion_r1963633036

cdesiniotis avatar Feb 21 '25 00:02 cdesiniotis

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

github-actions[bot] avatar Nov 04 '25 22:11 github-actions[bot]

This is no longer needed. 🚀

jfroy avatar Nov 18 '25 17:11 jfroy