garak icon indicating copy to clipboard operation
garak copied to clipboard

probe: add Arabic DAN

Open Eaalghamdi opened this issue 1 year ago • 5 comments

Signed-off-by: Emad Alghamdi [email protected]

I added Arabic translation of all DAN probes which were quality checked by human to ensure suitability to the Arabic language, added Arabic detector for the probe. The new probes and detectors passed the test during development.

Eaalghamdi avatar Nov 21 '24 10:11 Eaalghamdi

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

github-actions[bot] avatar Nov 21 '24 10:11 github-actions[bot]

I have read the DCO Document and I hereby sign the DCO

Eaalghamdi avatar Nov 23 '24 15:11 Eaalghamdi

recheck

Eaalghamdi avatar Nov 23 '24 15:11 Eaalghamdi

It also seems that the code here includes donotanswer ala #1017 -- is that intended?

erickgalinkin avatar Nov 26 '24 17:11 erickgalinkin

@erickgalinkin, I think the bcp47 selection can be deferred. For now for non en probes should not be marked active by default and the detectors will only be selected explicitly be a probe or override. This puts the onus on the user to force selection of this items via configuration options when preforming a run.

Also all comments I made in review or #1017 will apply here as well. For now we can have the separate languages as unique classes that can be selected explicitly and in future iterations we can consolidate those classes into language specific instances of one class.

jmartin-tech avatar Nov 26 '24 17:11 jmartin-tech