cutlass icon indicating copy to clipboard operation
cutlass copied to clipboard

add Conv singlestage

Open leiwen83 opened this issue 4 years ago • 11 comments

This commit set add singlestage conv for cutlass

leiwen83 avatar Oct 10 '21 07:10 leiwen83

@hwu36 Hi,

Could you help review this patch, whether this singlestage patch could be merged?

Thx, Lei

leiwen83 avatar Oct 19 '21 02:10 leiwen83

Thanks, I will take a look and run the tests. If any change is needed, I will do it myself and push to your branch.

hwu36 avatar Oct 19 '21 03:10 hwu36

@leiwen83 can you provide performance results to justify this PR?

mnicely avatar Dec 01 '21 19:12 mnicely

@leiwen83 can you provide performance results to justify this PR?

Seem to me there is no performance gain for this single stage conv being added. So maybe we could close this PR for now.

leiwen83 avatar Dec 02 '21 10:12 leiwen83

This is a useful feature for T4 or maybe small ampere cards. I will work on it hopefully this month.

hwu36 avatar Dec 07 '21 15:12 hwu36

We do have singlestage mma pipeline for GEMMs. Do we have some use cases for T4 where single stage wins over 2-staged pipeline?

manishucsd avatar Dec 07 '21 18:12 manishucsd

We do have singlestage mma pipeline for GEMMs. Do we have some use cases for T4 where single stage wins over 2-staged pipeline?

Yes, most kernels picked by cublas on t4 are single stage ones.

hwu36 avatar Dec 07 '21 23:12 hwu36

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Jan 07 '22 00:01 github-actions[bot]

Hi @leiwen83 ,

Sorry for the delay. I am working on this one now. Have you tested your code in any way?

hwu36 avatar Feb 17 '22 20:02 hwu36

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Mar 19 '22 22:03 github-actions[bot]

This PR has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates.

github-actions[bot] avatar Sep 15 '22 21:09 github-actions[bot]