cutlass icon indicating copy to clipboard operation
cutlass copied to clipboard

[BUG+FIX] sgemm_sm80: s2r_atom_* type is incomplete

Open osayamenja opened this issue 6 months ago • 3 comments

Describe the bug sgemm_sm80 fails to compile when dispatched to non-fp16 gemm_* functions.

Steps/Code to reproduce bug Change TA = TB = float or any non-fp16 type.

Expected behavior Code should compile.

Environment details (please complete the following information): A100

Additional context For here and elsewhere, we need to use CopyAtom<AutoVectorizingCopy, TA>.

osayamenja avatar Jun 09 '25 23:06 osayamenja

those are not expected to compile based on just changing the dtype. you will likely have to change every tiled copy and tiled mma. The goal of that example is not to be generic for all data types. That's what the CUTLASS API is for.

thakkarV avatar Jun 10 '25 00:06 thakkarV

I see, will close this then.

osayamenja avatar Jun 10 '25 00:06 osayamenja

Reopen, that example does specialize for half_t and I believe the templated functions were intended to be specialized for float but somehow remained a template. These should be fixed.

It appears to me that gemm_nt should be functional for float, but gemm_tn may be broken? Either way, it appears that neither one should be templated.

ccecka avatar Jun 10 '25 01:06 ccecka

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Aug 22 '25 13:08 github-actions[bot]

@osayamenja The fix is in the 4.2 tag release. Please reopen the issue if the fix doesn't work.

jwu1980 avatar Sep 17 '25 17:09 jwu1980