cuda-quantum icon indicating copy to clipboard operation
cuda-quantum copied to clipboard

Added definitions from header file

Open ParamThakkar123 opened this issue 1 year ago • 15 comments

Description

Addresses issue #1911

ParamThakkar123 avatar Jul 30 '24 06:07 ParamThakkar123

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Jul 30 '24 06:07 copy-pr-bot[bot]

CLA Assistant Lite bot All Contributors have signed the CLA.

github-actions[bot] avatar Jul 30 '24 06:07 github-actions[bot]

I have read the Contributor License Agreement and I hereby accept the Terms.

ParamThakkar123 avatar Jul 30 '24 06:07 ParamThakkar123

/ok to test

Command Bot: Processing...

khalatepradnya avatar Jul 30 '24 20:07 khalatepradnya

/ok to test

Command Bot: Processing...

khalatepradnya avatar Jul 31 '24 23:07 khalatepradnya

image

@khalatepradnya this doesn't give and error in other files but this some thing gives an error in qubit_qis.h . Why is this happening ?

ParamThakkar123 avatar Aug 01 '24 04:08 ParamThakkar123

@khalatepradnya can you please explain me what's the problem here ?? So I can try to fix this

ParamThakkar123 avatar Aug 04 '24 12:08 ParamThakkar123

image

@khalatepradnya this doesn't give and error in other files but this some thing gives an error in qubit_qis.h . Why is this happening ?

Is this the error message you get when building your branch locally? (I see that CI is failing with error: 'annotate' attribute requires a string)

khalatepradnya avatar Aug 05 '24 16:08 khalatepradnya

@khalatepradnya can you please explain me what's the problem here ?? So I can try to fix this

I don't see any changes to cmake in this PR. I suspect the build is not able to locate the new file, can you check target_include_directories?

khalatepradnya avatar Aug 05 '24 16:08 khalatepradnya

@khalatepradnya can you please explain me what's the problem here ?? So I can try to fix this

I don't see any changes to cmake in this PR. I suspect the build is not able to locate the new file, can you check target_include_directories?

Ok I will try this

ParamThakkar123 avatar Aug 05 '24 16:08 ParamThakkar123

@khalatepradnya I didn't find any issues with target_include_directories

ParamThakkar123 avatar Aug 05 '24 16:08 ParamThakkar123

image @khalatepradnya this doesn't give and error in other files but this some thing gives an error in qubit_qis.h . Why is this happening ?

Is this the error message you get when building your branch locally? (I see that CI is failing with error: 'annotate' attribute requires a string)

Unfortunately, __attribute__((annotate(thing))) isn't very smart and strictly requires a C style string literal to appear inline for thing. Sad, but true. So we can't use a symbolic for thing in these cases.

schweitzpgi avatar Sep 06 '24 17:09 schweitzpgi

@ParamThakkar123 do you want to take another stab at this one?

schweitzpgi avatar Sep 06 '24 17:09 schweitzpgi

@ParamThakkar123 do you want to take another stab at this one?

Yeah would like to work on this. But would need some help from your side not to solve this issue but to get a better understanding of this codebase.

ParamThakkar123 avatar Sep 06 '24 18:09 ParamThakkar123

@ParamThakkar123 do you want to take another stab at this one?

Yeah would like to work on this. But would need some help from your side not to solve this issue but to get a better understanding of this codebase.

Hi! If you want to continue investigating this build failure, I recommend first aligning with main and re-running the build. If you happen to have error message from your local build environment, please share it so we can debug further. Thanks!

khalatepradnya avatar Sep 27 '24 17:09 khalatepradnya