container-canary icon indicating copy to clipboard operation
container-canary copied to clipboard

Published 20 hours ago • verified publisher icon NVIDIA

Add --log-file argument and log test result details

Open KyleFromNVIDIA opened this issue 1 year ago • 4 comments

Add a --log-file argument for container-canary to write detailed logs, so that developers can see exactly how and why a test failed.

KyleFromNVIDIA avatar Feb 22 '24 21:02 KyleFromNVIDIA

I'd like to revive this, but I don't have write access here.

@KyleFromNVIDIA could you update this to latest main and add a PR description?

And @jacobtomlinson after that could you help us out with a review?

jameslamb avatar May 21 '24 20:05 jameslamb

@jameslamb I've added you to the codeowners team here. @KyleFromNVIDIA I was unable to add you as you're not a member of the @nvidia org, we probably need to figure out how to add you so that you can be added to the codeowners.

jacobtomlinson avatar May 22 '24 08:05 jacobtomlinson

I was unable to add you as you're not a member of the @NVIDIA org, we probably need to figure out how to add you so that you can be added to the codeowners.

I've fixed this, you can go ahead and add me.

KyleFromNVIDIA avatar May 22 '24 13:05 KyleFromNVIDIA

@jameslamb @jacobtomlinson Is there anything else left to address here?

KyleFromNVIDIA avatar Jul 01 '24 15:07 KyleFromNVIDIA