cccl icon indicating copy to clipboard operation
cccl copied to clipboard

Port thrust complex.cu tests to catch2_test_complex.cu

Open dunga1k58bh opened this issue 2 months ago • 5 comments

Description

closes #6589

  • Port all 15 test structs from complex.cu to catch2_test_complex.cu
  • Fix mistake in ComplexMemberOperators: change b_thrust vs b_thrust comparison to b_thrust vs b_std (line 385 in original file)

Checklist

  • [x] New or existing tests cover these changes.
  • [x] The documentation is up to date with these changes.

dunga1k58bh avatar Nov 13 '25 20:11 dunga1k58bh

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 13 '25 20:11 copy-pr-bot[bot]

/ok to test 90b6333

bernhardmgruber avatar Nov 13 '25 22:11 bernhardmgruber

@dunga1k58bh thank you for taking a stab at this! This is super helpful!

bernhardmgruber avatar Nov 13 '25 22:11 bernhardmgruber

😬 CI Workflow Results

🟥 Finished in 3h 40m: Pass: 98%/70 | Total: 3d 07h | Max: 3h 39m | Hits: 41%/113033

See results here.

github-actions[bot] avatar Nov 14 '25 01:11 github-actions[bot]

@bernhardmgruber A pull request failed, but I think it's due to an environment configuration error. What should I do now?

Command ''sccache' '--start-server'' failed with status 2. Retrying in 30 seconds...
Attempt 5 of 5: Running command ''sccache' '--start-server''
sccache: Starting sccache v0.12.0-rapids.10...
sccache: error: Server startup failed: cache storage failed to read: PermissionDenied (permanent) at read => S3Error { code: "SignatureDoesNotMatch", message: "The request signature we calculated does not match the signature you provided. Check your key and signing method.", resource: "", request_id: "PYVQVY1EB7K9VKAF" }

dunga1k58bh avatar Nov 14 '25 03:11 dunga1k58bh

/ok to test 3747cf2

bernhardmgruber avatar Nov 15 '25 23:11 bernhardmgruber

@bernhardmgruber A pull request failed, but I think it's due to an environment configuration error. What should I do now?

We sometimes have CI hickups that require us to manually rerun the CI. Sorry about that! Just wait or ping a maintainer if this happens!

bernhardmgruber avatar Nov 15 '25 23:11 bernhardmgruber

😬 CI Workflow Results

🟥 Finished in 2h 57m: Pass: 98%/70 | Total: 2d 15h | Max: 2h 43m | Hits: 78%/114809

See results here.

github-actions[bot] avatar Nov 16 '25 02:11 github-actions[bot]

@bernhardmgruber Failed due to out of memory

2025-11-16T00:38:31.6520669Z 1 catastrophic error detected in the compilation of "C:/cccl/thrust/testing/catch2_test_transform.cu".
2025-11-16T00:38:31.6521194Z Compilation terminated.
2025-11-16T00:38:31.6526890Z Catastrophic error: out of memory

dunga1k58bh avatar Nov 16 '25 04:11 dunga1k58bh

I see an OOM error at compile-time:

  C:\cccl\libcudacxx\include\cuda/std/__fwd/subrange.h(47): catastrophic error: out of memory
              enable_if_t<(_Kind == subrange_kind::sized || !sized_sentinel_for<_Sent, _Iter>), int> = 0>
                           ^
            detected during:
              instantiation of

so I guess the compiler hit a limit on the runner.

bernhardmgruber avatar Nov 16 '25 21:11 bernhardmgruber

🥳 CI Workflow Results

🟩 Finished in 1d 00h: Pass: 100%/70 | Total: 2d 16h | Max: 2h 43m | Hits: 78%/115481

See results here.

github-actions[bot] avatar Nov 16 '25 23:11 github-actions[bot]

/ok to test 1bfcc1e

bernhardmgruber avatar Nov 17 '25 12:11 bernhardmgruber

🥳 CI Workflow Results

🟩 Finished in 2h 16m: Pass: 100%/70 | Total: 22h 43m | Max: 2h 13m | Hits: 99%/115481

See results here.

github-actions[bot] avatar Nov 17 '25 15:11 github-actions[bot]