cccl icon indicating copy to clipboard operation
cccl copied to clipboard

MVP for disabling nvtx ranges for `thrust::seq`

Open gonidelis opened this issue 1 month ago • 5 comments

fixes https://github.com/NVIDIA/cccl/issues/6298

by disabling NVTX ranges for thrust::seq. This PR specifically tracks the thrust algorithms involved in host_vector::push_back() operations and disables NVTX ranges just for these.

The disabling basically evaluates at compile time whether the policy passed to the thrust algorithm (and subsequently to should_enable_nvtx_for_policy()) is thrust::seq or any derivatives using CRTP.

Upon approval of the utility provided here, I will add all the remaining thrust algorithms.

I did isolate and run profiles on the cudf code that pointed to the problem and after the changes I got zero nvtx ranges for these lines in the profile.

gonidelis avatar Oct 31 '25 00:10 gonidelis

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Oct 31 '25 00:10 copy-pr-bot[bot]

@bernhardmgruber @miscco now that I am thinking. Is a test expected for these facilities? And should it be under libcu++ better of maybe? Could be in libcudacxx/include/cuda/__nvtx/nvtx.h 👀

gonidelis avatar Nov 05 '25 18:11 gonidelis

@bernhardmgruber @miscco now that I am thinking. Is a test expected for these facilities?

Good point! Please add a test if you come up with a good idea on how to test it.

bernhardmgruber avatar Nov 05 '25 19:11 bernhardmgruber

🥳 CI Workflow Results

🟩 Finished in 3h 34m: Pass: 100%/70 | Total: 3d 15h | Max: 3h 30m | Hits: 19%/115311

See results here.

github-actions[bot] avatar Nov 05 '25 22:11 github-actions[bot]

😬 CI Workflow Results

🟥 Finished in 3h 04m: Pass: 98%/70 | Total: 3d 01h | Max: 2h 46m | Hits: 50%/112891

See results here.

github-actions[bot] avatar Nov 14 '25 00:11 github-actions[bot]

🥳 CI Workflow Results

🟩 Finished in 2d 05h: Pass: 100%/70 | Total: 3d 04h | Max: 3h 17m | Hits: 50%/115311

See results here.

github-actions[bot] avatar Nov 16 '25 02:11 github-actions[bot]